fix loading of skill, remove stale nbextensions no_exec_dunder and nbviewer_theme #906
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
jcb91
commented
Mar 1, 2017
jcb91
commented
- no_exec_dunder functionality is provided by freeze
- nbviewer_theme hasn't been updated for 4.x, and seems to be a subset of css_selector anyway.
- skill is a bare codemirror mode, which doesn't provide the expected load_ipython_extension method, causing the notebook to record a misleading error. Add a main.js script to load the codemirror mode.
otherwise notebook throws an error, and the nbextension gets loaded anyway.
This hasn't been updated for 4.x, and seems to be a subset of css_selector anyway...
|
👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.