Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update function import for when Notebook 7 is present #1653

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

RRosio
Copy link
Collaborator

@RRosio RRosio commented Oct 11, 2023

As with #1649, this import statement can be updated to import from jupyter_server when Notebook 7 is present rather than Notebook <= 6.

@RRosio
Copy link
Collaborator Author

RRosio commented Oct 16, 2023

Hi @juhasch, is there anyway I can help with the release of jupyter_contrib_nbextensions for Notebook7/ NbClassic compatibility? I was added along with a few others on the PyPI side but I don't have the required rights on this repo to help merge the PRs. As long as this looks okay, I would be happy to make a release to help with NbClassic compatibility.

@juhasch
Copy link
Member

juhasch commented Oct 30, 2023

Hi @RRosio, sorry for the delay. I made you admin.

@RRosio
Copy link
Collaborator Author

RRosio commented Oct 31, 2023

No worries @juhasch, thank you for your help with this!

try:
from notebook.notebookapp import list_running_servers
except ModuleNotFoundError:
from jupyter_server.serverapp import list_runnning_servers

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small typo here I think, list_runnning_servers should be list_running_servers

@zxem
Copy link

zxem commented Jan 23, 2024

@RRosio Hello, is there going to be a new release with this change to support Notebook 7?
Thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants