Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[dragAndDrop] use markdown syntax instead of html #929

Merged
merged 3 commits into from
Apr 9, 2017

Conversation

xNok
Copy link
Contributor

@xNok xNok commented Mar 27, 2017

same as #925, without the merge commit into the history

As discus in jupyter/nbconvert#552

[nbconvert] don't support pdf export from general HTML markup in markdown cells
Thus I think it is a better Idea to use markdown syntax, so this extension stays coherent with the ecosystem.

```html
<img src="http://127.0.0.1:8888/notebooks/myimage.png"/>
```markdown
![](http://127.0.0.1:8888/notebooks/myimage.png)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be better to shown an example using a local file, not a URL.

@juhasch
Copy link
Member

juhasch commented Mar 27, 2017

Thanks, looks good to me, I only have a minor note.
As this change is needed for PDF support, it might be useful to change the example.

@xNok
Copy link
Contributor Author

xNok commented Mar 30, 2017

You are right the tag generated contains only the file name. (the image is uploaded next to the notebook file)

@mpacer
Copy link

mpacer commented Apr 4, 2017

Looks like the conda recipe is broken — it's using py3.6 even on what is ostensibly a py3.4 build. That may be related to the error.

@jcb91
Copy link
Member

jcb91 commented Apr 4, 2017 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants