[tree-filter] Make search case insensitve and accept RegExp #948
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 6, 2017 16:49
Update tree-filter.index.js to make search case insensitive
wikiped
changed the title
|
I think there's an issue requesting case sensitivity on the upstream repo https://github.com/jdfreder/tree-filter so it might be worth adding this there too? It'd also be good to either make regex optional, or at least a little more obvious that it's happening (e.g. readme, tooltips) |
|
I think making the regex configurable sounds good. |
[tree-filter] support optional case-sensitivity and regex syntax
|
The patch was added to make case sensitivity / RegExp optional. |
|
Thanks @jcb91 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently filtering entries in the file tree is Case Sensitive. This patch will make it case insensitive and it will also accept Regular Expressions as valid search strings.