Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deadcode in eventloops.py #349

Closed
Carreau opened this issue Sep 25, 2018 · 3 comments
Closed

deadcode in eventloops.py #349

Carreau opened this issue Sep 25, 2018 · 3 comments

Comments

@Carreau
Copy link
Member

Carreau commented Sep 25, 2018

    from IPython.external.qt_for_kernel import QtCore

    if _use_appnope() and kernel._darwin_app_nap:
        from appnope import nope_scope as context
    else:
        from contextlib import contextmanager
        @contextmanager
        def context():
            yield

context seem to be unused in rest of the file.

@matholiveira91
Copy link

#try to make it generic

@osule
Copy link

osule commented Oct 5, 2018

@matholiveira91 I don't see context used outside this module in the project.
Do you supposed that it is used in some other project?

I can help on this issue.
cc: @Carreau

osule added a commit to osule/ipykernel that referenced this issue Oct 5, 2018
This deletes unused context name in ipykernel.eventloops module
and fixes ipython#349
@Carreau
Copy link
Member Author

Carreau commented Oct 5, 2018

closed by #355 ans #357 Good job all.

@Carreau Carreau closed this as completed Oct 5, 2018
@minrk minrk added this to the 5.1 milestone Oct 8, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants