Explicitly close memory object streams #1253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidbrochart
approved these changes
Jun 28, 2024
ianthomas23
force-pushed
the
1252_close_memory_object_streams
branch
from
3058687
to
e263710
Compare
|
This fixes all the local CI runs, except the docs which is some other problem. I am self-merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1252.
When using anyio
MemoryObjectReceiveStreamandMemoryObjectSendStreamwe must explicitly close them when we have finished with them. This wasn't necessary with anyio 4.3.0 but is with 4.4.0 as otherwise warnings/errors are issued which break our CI.This is only actually an issue in CI as our only explicit use of memory object streams is in
TestSession.