handle KeyboardInterrupt with %gui asyncio #281
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when interrupted, re-enter eventloop and don't close it only close the eventloop when we are done for good. Also avoid any cleanup when someone else is already running the eventloop (e.g. tornado 5).
easier debugging when there are errors
takluyver
reviewed
Nov 24, 2017
ipykernel/eventloops.py
Outdated
| except KeyboardInterrupt: | ||
| continue | ||
| except Exception as e: | ||
| error = e | ||
| loop.run_until_complete(loop.shutdown_asyncgens()) |
There was a problem hiding this comment.
The docs say that shutdown_asyncgens is new in 3.6, so this code might not work with 3.5? But maybe it's only on the abstract class that the method is new. This is already in the code, so I'm happy to merge this PR anyway, but it's worth checking.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
when interrupted, re-enter eventloop and don't close it (same as all the other eventloops)
Only close the eventloop when we are done for good AND we are responsible for running it.
Also avoid any cleanup when someone else is already running the eventloop (e.g. tornado 5).
closes #263
I'll try add a test for this before it's ready to merge.