Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env parameter to kernel installation #541

Merged
merged 3 commits into from
Aug 24, 2020
Merged

Conversation

e-roux
Copy link

@e-roux e-roux commented Aug 23, 2020

This delivers a basic support of env parameter for setting kernel environment variables.

Optional environment variables can be set in kernels, this modification sets multiple environments variables on installation.

If the proposal is accepted, env. var. correctness can be added e.g. based on Open Group Base Specifications

Basic support of env parameter for setting kernel environment
variable
Copy link
Contributor

@blink1073 blink1073 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you! Mind adding a test here?

@blink1073 blink1073 added this to the 5.5 milestone Aug 24, 2020
@e-roux
Copy link
Author

e-roux commented Aug 24, 2020

Added a test based on pytest, hope it is ok (nose seems to be unmaintained since years).

@blink1073
Copy link
Contributor

Added a test based on pytest, hope it is ok (nose seems to be unmaintained since years).

Yep, we only have nose around for a few utility functions. Thanks for adding a test!

@blink1073 blink1073 merged commit 6ba7540 into ipython:master Aug 24, 2020
@e-roux e-roux deleted the cli branch September 5, 2020 10:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants