Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed filtering of stack frames for testing #633

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

JohanMabille
Copy link
Contributor

Fixes #629

@mlucool can you confirm?

@JohanMabille JohanMabille force-pushed the debug_osx branch 2 times, most recently from 3a9e4b7 to 5e9668f Compare April 12, 2021 14:33
@mlucool
Copy link
Contributor

mlucool commented Apr 12, 2021

This works for me - thanks! Will you release a new alpha after as well?

@JohanMabille
Copy link
Contributor Author

I don't have the permission for that, but I'm sure we can ask @blink1073 ;) But I need to understand the failure before (although it looks totally unrelated).

@JohanMabille
Copy link
Contributor Author

According to @davidbrochart, the failures are due to the last release of Jupyter Client:

for instance get_msg() doesn't have a block kwargs anymore

David is working on a PR to fix the tests, I will rebase when it is merged.

@SylvainCorlay
Copy link
Member

Let's tag a release.

@SylvainCorlay
Copy link
Member

6.0.0a3 is out with that fix.

@JohanMabille JohanMabille deleted the debug_osx branch April 12, 2021 20:35
@Carreau Carreau added this to the 6.0 milestone Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IPykernel Debugger
4 participants