Add watchfd keyword to InProcessKernel OutStream initialization #727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Setting `watchfd`to False when creating OutStream instances for `stdout` prevents an exception caused by the lack of a file descriptor in the stream used by the InProcessKernel .
|
Thank you for the quick response. I will release a new version of NeXpy, which will depend on this update. Is it safe for me to assume that it will be included in the v6.0.2 release? It doesn't matter when that is - I will just adjust my dependencies to include future releases. |
|
Yes, just waiting for review on the changelog |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On some systems, the creation of OutStream instances to handle
stdoutandstderrtriggers an exception when using the InProcessKernel. This is because the default keyword arguments creating the stream assume there is a file descriptor and callsfileno, which triggers anio.UnsupportedOperation("fileno")exception. The problem is new to v6. This PR addswatchfd=Falseto the default OutStreams for bothstdoutandstderrin the InProcessKernel. This fixes #724.