Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/add new dronecan feature docs #110

Open
wants to merge 9 commits into
base: development
Choose a base branch
from

Conversation

vertiq-jordan
Copy link
Contributor

No description provided.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The formatting level things were wrong, and got in my way. So, I went through and made them right.

This request has no payload fields. The response message from the receiving node should include the status of the node as defined by the NodeStatus message, the
software and hardware version of the node, and the name of the node. For Vertiq modules, the name of each node is currently “iq_motion.esc”.

Refer to the `uavcan.protocol.GetNodeInfo section of Standard Data Types <https://dronecan.github.io/Specification/7._List_of_standard_data_types/#getnodeinfo>`_ in the specification
for more details

uavcan.protocol.dynamic_node_id.Allocation (Data Type ID = 1)
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I swear it's data type ID 1 also
image

@vertiq-jordan vertiq-jordan requested review from iq-fred and removed request for iq-fred November 6, 2024 17:43
@vertiq-jordan vertiq-jordan requested a review from iq-fred November 6, 2024 19:12
@vertiq-jordan vertiq-jordan changed the base branch from master to development November 6, 2024 19:13
@iq-fred
Copy link
Contributor

iq-fred commented Nov 8, 2024

@vertiq-jordan You may want to point this to a separate DroneCAN holding branch or whatever instead of develop so we can control when this goes public. I only want to publicize it once some newer firmware releases go out supporting more of this stuff

@iq-fred
Copy link
Contributor

iq-fred commented Nov 13, 2024

@vertiq-jordan You may want to point this to a separate DroneCAN holding branch or whatever instead of develop so we can control when this goes public. I only want to publicize it once some newer firmware releases go out supporting more of this stuff

@vertiq-jordan Thoughts on this? I see its still pointing at develop

@vertiq-jordan
Copy link
Contributor Author

@vertiq-jordan You may want to point this to a separate DroneCAN holding branch or whatever instead of develop so we can control when this goes public. I only want to publicize it once some newer firmware releases go out supporting more of this stuff

@vertiq-jordan Thoughts on this? I see its still pointing at develop

whoops, must have missed this. My plan was to just let it simmer in this PR until we're ready to hit the merge button. Putting it into a holding branch is the same as it sitting here

@iq-fred
Copy link
Contributor

iq-fred commented Nov 13, 2024

@vertiq-jordan You may want to point this to a separate DroneCAN holding branch or whatever instead of develop so we can control when this goes public. I only want to publicize it once some newer firmware releases go out supporting more of this stuff

@vertiq-jordan Thoughts on this? I see its still pointing at develop

whoops, must have missed this. My plan was to just let it simmer in this PR until we're ready to hit the merge button. Putting it into a holding branch is the same as it sitting here

@vertiq-jordan Ok, just as long as you don't accidentally hit the merge button

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants