Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tx_signer: log entire transaction at info level #154

Merged
merged 1 commit into from
Oct 6, 2020

Conversation

tony-iqlusion
Copy link
Member

There's too much noise going on at the debug level to find the information we need quickly.

This logs a properly formatted hex string at the info level containing the entire transaction to be broadcast.

There's too much noise going on at the debug level to find the
information we need quickly.

This logs a properly formatted hex string at the info level containing
the entire transacstion to be broadcast.
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (develop@1a58c77). Click here to learn what that means.
The diff coverage is 0.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##             develop     #154   +/-   ##
==========================================
  Coverage           ?   22.60%           
==========================================
  Files              ?       60           
  Lines              ?     2446           
  Branches           ?        0           
==========================================
  Hits               ?      553           
  Misses             ?     1893           
  Partials           ?        0           
Impacted Files Coverage Δ
src/commands/yubihsm/keys.rs 0.00% <ø> (ø)
src/commands/yubihsm/keys/generate.rs 0.00% <0.00%> (ø)
src/commands/yubihsm/keys/list.rs 0.00% <0.00%> (ø)
src/config/provider.rs 0.00% <0.00%> (ø)
src/keyring.rs 0.00% <0.00%> (ø)
src/tx_signer.rs 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1a58c77...ae93ebb. Read the comment docs.

@tony-iqlusion tony-iqlusion merged commit a946865 into develop Oct 6, 2020
@tony-iqlusion tony-iqlusion deleted the log-entire-tx-at-info-level branch October 6, 2020 23:51
@tony-iqlusion tony-iqlusion mentioned this pull request Oct 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants