Update dependency Next.js to v9.1.4 #315
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
"Upgrade to latest release in a follow-up since they changed how they polyfill." See https://github.com/mui-org/material-ui/pull/18441/files#r386433177.
Next.js supports "src" directory since version 9.1: https://nextjs.org/blog/next-9-1#src-directory-support
The public directory was also introduced in version 9.1: https://nextjs.org/blog/next-9-1#public-directory-support.
npm run dev
Next.js "will automatically prefetch <Link> components as they appear in-viewport" since version 9.0. See: - https://nextjs.org/blog/next-9#production-optimizations - https://nextjs.org/docs/api-reference/next/link
Container was deprecated in v9.0.4: https://err.sh/zeit/next.js/app-container-deprecated
1 task
For now just to make the tests run in CI. Later we can figure out if it's "declaration" that should go away.
"Error while running `getDataFromTree` TypeError: Cannot read property 'pathname' of null". There's a lot of code I added in this commit just to debug what was going on, but the important part is the usage of `AppTree` instead of the composed `App` when using `getDataFromTree()`. The issue is documented here: vercel/next.js#7731 And solved here: vercel/next.js#7732
|
In the terminal log below, why is WithData.getInitialProps() -> ctx: [ 'AppTree', 'Component', 'router', 'ctx' ]
WithData.getInitialProps() -> router: { pathname: '/admin/provas/detalhes' }
OliApp.getInitialProps -> appCtx: [ 'AppTree', 'Component', 'router', 'ctx' ]
OliApp.getInitialProps -> appCtx -> Component: [Function: PageAdminExamDetails] { getInitialProps: [AsyncFunction] }
OliApp.getInitialProps -> appCtx -> router: { pathname: '/admin/provas/detalhes' }
PageAdminExamDetails.getInitialProps() -> pageCtx: [
'err',
'req',
'res',
'pathname',
'query',
'asPath',
'AppTree',
'apolloClient'
]
OliApp.getInitialProps -> pageProps: [ 'fakeProp', 'loggedInUser' ]
WithData -> appProps: [ 'pageProps' ]
Awaiting getDataFromTree()...
WithData.render()
OliApp.render() -> props: [ 'pageProps', 'apolloClient', 'Component', 'router' ]
OliApp.render() -> props -> router: { pathname: '/admin/provas/detalhes' }
AppWrapper -> router: { pathname: '/admin/provas/detalhes' }
PageAdminExamDetails() -> props: [ 'fakeProp', 'loggedInUser' ]
WithData.render()
OliApp.render() -> props: [ 'pageProps', 'apolloClient', 'Component', 'router' ]
OliApp.render() -> props -> router: { pathname: '/admin/provas/detalhes' }
AppWrapper -> router: { pathname: '/admin/provas/detalhes' }
PageAdminExamDetails() -> props: [ 'fakeProp', 'loggedInUser' ]
getDataFromTree() finished -> data extracted
MyDocument.getInitialProps()
WithData.render()
OliApp.render() -> props: [ 'Component', 'router', 'apolloState', 'pageProps' ]
OliApp.render() -> props -> router: { pathname: '/admin/provas/detalhes' }
AppWrapper -> router: { pathname: '/admin/provas/detalhes' }
PageAdminExamDetails() -> props: [ 'fakeProp', 'loggedInUser' ]
MyDocument.render()Another thing I noticed is that
|
This reverts commit bbc417d.
...in package-lock.json https://stackoverflow.com/a/54127283/1787829
Babel, through Next.js, need this very badly: "The following changes are being made to your tsconfig.json file: - compilerOptions.isolatedModules must be true (requirement for babel)"
"error TS1208: All files must be modules when the '--isolatedModules' flag is provided."
I removed by mistake when updating Next.js in 274a008
Codecov Report
@@ Coverage Diff @@
## master #315 +/- ##
==========================================
+ Coverage 23.08% 23.43% +0.34%
==========================================
Files 105 106 +1
Lines 1412 1434 +22
Branches 230 230
==========================================
+ Hits 326 336 +10
- Misses 1085 1097 +12
Partials 1 1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This partially solves #304