Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Delete Kokoro directory #10325

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Delete Kokoro directory #10325

merged 2 commits into from
Sep 7, 2022

Conversation

GMNGeoffrey
Copy link
Contributor

@GMNGeoffrey GMNGeoffrey commented Sep 7, 2022 •
edited
Loading

We no longer use Kokoro for CI. There are still some references to it
throughout the repo, but no references to these paths. I'll clean up
the other references separately.

Part of #9855

@GMNGeoffrey GMNGeoffrey changed the title delete kokoro Delete Kokoro directory Sep 7, 2022
@GMNGeoffrey GMNGeoffrey added the infrastructure Relating to build systems, CI, or testing label Sep 7, 2022
@GMNGeoffrey GMNGeoffrey marked this pull request as ready for review September 7, 2022 21:50
ScottTodd
ScottTodd approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@ScottTodd ScottTodd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought we might have had some references to build_tools/kokoro/ in old buildkite pipelines or other scripts, but it looks like we don't (anymore?).

@GMNGeoffrey
Copy link
Contributor Author

I thought we might have had some references to build_tools/kokoro/ in old buildkite pipelines or other scripts, but it looks like we don't (anymore?).

Nothing in the repository. I think I fixed some of them at some point. I'm also not super sympathetic if someone hardcoded a path to a Kokoro directory from something other than Kokoro and not checked into source control...

@GMNGeoffrey GMNGeoffrey merged commit ec97010 into iree-org:main Sep 7, 2022
@GMNGeoffrey GMNGeoffrey deleted the delete-kokoro branch September 7, 2022 22:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes

@pzread pzread Awaiting requested review from pzread

Assignees
No one assigned
Labels
infrastructure Relating to build systems, CI, or testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GMNGeoffrey @ScottTodd