Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable iree/tests/e2e/regression/globals.mlir.test under ASan. #10892

Merged
merged 2 commits into from
Oct 25, 2022

Conversation

ScottTodd
Copy link
Member

@ScottTodd ScottTodd commented Oct 24, 2022

Seeing this test flake on a few presubmits:
https://github.com/iree-org/iree/actions/runs/3316089449/jobs/5477477103
https://github.com/iree-org/iree/actions/runs/3316263166/jobs/5477856081

Looks like #5716

FAIL: IREE :: e2e/regression/globals.mlir (1 of 1)
******************** TEST 'IREE :: e2e/regression/globals.mlir' FAILED ********************
Script:
--
: 'RUN: at line 1';   iree-run-mlir --iree-input-type=mhlo --iree-hal-target-backends=vmvx /work/tests/e2e/regression/globals.mlir | FileCheck /work/tests/e2e/regression/globals.mlir
: 'RUN: at line 2';   [[ $IREE_VULKAN_DISABLE == 1 ]] || (iree-run-mlir --iree-input-type=mhlo --iree-hal-target-backends=vulkan-spirv /work/tests/e2e/regression/globals.mlir | FileCheck /work/tests/e2e/regression/globals.mlir)
--
Exit Code: 1

Command Output (stderr):
--
Tracer caught signal 11: addr=0x0 pc=0x624e79 sp=0x7f87b02e3d30
==39757==LeakSanitizer has encountered a fatal error.
==39757==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1
==39757==HINT: LeakSanitizer does not work under ptrace (strace, gdb, etc)

--

********************
********************
Failed Tests (1):
  IREE :: e2e/regression/globals.mlir

The other tests in that suite either don't use Vulkan or can lower to just VM calls (no HAL):

SRCS
"fill_i64.mlir"
"globals.mlir"
"libm_linking.mlir"
"scalar.mlir"
"trace_dispatch_tensors.mlir"
"unused_args.mlir"

skip-ci

@ScottTodd ScottTodd added the infrastructure Relating to build systems, CI, or testing label Oct 24, 2022
@ScottTodd ScottTodd enabled auto-merge (squash) October 24, 2022 23:40
@@ -130,6 +130,7 @@ declare -a excluded_tests=(
"iree/tests/e2e/models/mnist_fake_weights.mlir.test"
"iree/tests/e2e/models/resnet50_fake_weights.mlir.test"
"iree/tests/e2e/models/unidirectional_lstm.mlir.test"
"iree/tests/e2e/regression/globals.mlir.test"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe add TODO(#5716) to remind us the reason to disable it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's already there a few lines up.

@ScottTodd ScottTodd merged commit afee31e into iree-org:main Oct 25, 2022
@ScottTodd ScottTodd deleted the asan-flake-globals branch October 25, 2022 16:30
PhaneeshB pushed a commit to PhaneeshB/iree that referenced this pull request Oct 31, 2022
…-org#10892)

Seeing this test flake on a few presubmits:
https://github.com/iree-org/iree/actions/runs/3316089449/jobs/5477477103
https://github.com/iree-org/iree/actions/runs/3316263166/jobs/5477856081

Looks like iree-org#5716

```
FAIL: IREE :: e2e/regression/globals.mlir (1 of 1)
******************** TEST 'IREE :: e2e/regression/globals.mlir' FAILED ********************
Script:
--
: 'RUN: at line 1';   iree-run-mlir --iree-input-type=mhlo --iree-hal-target-backends=vmvx /work/tests/e2e/regression/globals.mlir | FileCheck /work/tests/e2e/regression/globals.mlir
: 'RUN: at line 2';   [[ $IREE_VULKAN_DISABLE == 1 ]] || (iree-run-mlir --iree-input-type=mhlo --iree-hal-target-backends=vulkan-spirv /work/tests/e2e/regression/globals.mlir | FileCheck /work/tests/e2e/regression/globals.mlir)
--
Exit Code: 1

Command Output (stderr):
--
Tracer caught signal 11: addr=0x0 pc=0x624e79 sp=0x7f87b02e3d30
==39757==LeakSanitizer has encountered a fatal error.
==39757==HINT: For debugging, try setting environment variable LSAN_OPTIONS=verbosity=1:log_threads=1
==39757==HINT: LeakSanitizer does not work under ptrace (strace, gdb, etc)

--

********************
********************
Failed Tests (1):
  IREE :: e2e/regression/globals.mlir
```

The other tests in that suite either don't use Vulkan or can lower to
just VM calls (no HAL):
https://github.com/iree-org/iree/blob/87c5f3f353f9b733f137004c01673f6385515823/tests/e2e/regression/CMakeLists.txt#L16-L22

skip-ci
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure Relating to build systems, CI, or testing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants