Pad fusion bufferization workaround. #12425
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It seems like handling the code generated by the tiling of pad operations needs more work in bufferization. To unblock the work of handling pad operations natively in IREE, iree-org#11273 (comment) is implemented here as a workaround. To ensure bufferization without allocation, yields of the then and else branch and the result of the `scf.if` are all tied together. If the `then` and `else` come from different bindings, then this would be illegal (because a copy is needed). This example led to adding more constraints on what sets can be merged during the `BufferizationAnalysis` to avoid merging sets that have constants or have two different `interface_bindings`.
MaheshRavishankar
added
the
(deprecated) buildkite:benchmark-android
added 2 commits
February 28, 2023 12:09
MaheshRavishankar
force-pushed
the
pad_fusion_bufferization_workaround
branch
from
a866eb7
to
58fbc23
Compare
Abbreviated Android Benchmark Summary@ commit 90d6f471f6c891772a465f87f026892f153ffa6d (vs. base 17eafc9a230e31744224026d77cf46982e5c0a17) Regressed Latencies 🚩
[Top 3 out of 6 results showed] Improved Latencies 🎉
For more information: |
hanhanW
approved these changes
Mar 2, 2023
compiler/src/iree/compiler/Codegen/Common/ConvertToDestinationPassingStylePass.cpp
Outdated
Show resolved
Hide resolved
qedawkins
pushed a commit
to qedawkins/iree
that referenced
this pull request
Apr 2, 2023
It seems like handling the code generated by the tiling of pad operations needs more work in bufferization. To unblock the work of handling pad operations natively in IREE, iree-org#11273 (comment) is implemented here as a workaround. To ensure bufferization without allocation, yields of the then and else branch and the result of the scf.if are all tied together. If the then and else come from different bindings, then this would be illegal (because a copy is needed). This example led to adding more constraints on what sets can be merged during the BufferizationAnalysis to avoid merging sets that have constants or have two different interface_bindings. benchmarks: x86_64, cuda
Merged
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
It seems like handling the code generated by the tiling of pad operations needs more work in bufferization. To unblock the work of handling pad operations natively in IREE, #11273 (comment) is implemented here as a workaround. To ensure bufferization without allocation, yields of the then and else branch and the result of the scf.if are all tied together. If the then and else come from different bindings, then this would be illegal (because a copy is needed). This example led to adding more constraints on what sets can be merged during the BufferizationAnalysis to avoid merging sets that have constants or have two different interface_bindings. benchmarks: x86_64, cuda
rengolin
pushed a commit
to plaidml/iree
that referenced
this pull request
May 2, 2023
It seems like handling the code generated by the tiling of pad operations needs more work in bufferization. To unblock the work of handling pad operations natively in IREE, iree-org#11273 (comment) is implemented here as a workaround. To ensure bufferization without allocation, yields of the then and else branch and the result of the scf.if are all tied together. If the then and else come from different bindings, then this would be illegal (because a copy is needed). This example led to adding more constraints on what sets can be merged during the BufferizationAnalysis to avoid merging sets that have constants or have two different interface_bindings. benchmarks: x86_64, cuda
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
It seems like handling the code generated by the tiling of pad operations needs more work in bufferization. To unblock the work of handling pad operations natively in IREE, iree-org#11273 (comment) is implemented here as a workaround. To ensure bufferization without allocation, yields of the then and else branch and the result of the scf.if are all tied together. If the then and else come from different bindings, then this would be illegal (because a copy is needed). This example led to adding more constraints on what sets can be merged during the BufferizationAnalysis to avoid merging sets that have constants or have two different interface_bindings. benchmarks: x86_64, cuda
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It seems like handling the code generated by the tiling of pad operations needs more work in bufferization. To unblock the work of handling pad operations natively in IREE,
#11273 (comment) is implemented here as a workaround.
To ensure bufferization without allocation, yields of the then and else branch and the result of the
scf.ifare all tied together. If thethenandelsecome from different bindings, then this would be illegal (because a copy is needed). This example led to adding more constraints on what sets can be merged during theBufferizationAnalysisto avoid merging sets that have constants or have two differentinterface_bindings.benchmarks: x86_64, cuda