Use git directly instead of actions/checkout on Windows
#13186
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GMNGeoffrey
added
infrastructure
ScottTodd
approved these changes
Apr 20, 2023
|
Still seeing high variance, unfortunately. This might be a net improvement though.
|
|
It's getting monotonically slower (⊙ _◎) |
jpienaar
pushed a commit
that referenced
this pull request
May 1, 2023
The GitHub-provided `actions/checkout` action is for some reason unusably slow on the large managed Windows runners. We assumed this was because of some tricky IO issue or something, but I decide to just try directly using `git` commands to see and lo the checkout time goes from 10 minutes to 1.5 🚀 With the caching improvements from #13183, this gets the Windows build down under 10 minutes, which means we can run it on presubmit (left for a future PR). Part of #11009 Tested: Enabled this workflow on push to my branch: https://github.com/openxla/iree/actions/runs/4750681034/jobs/8439091687 skip-ci: this only affects the Windows job, which isn't run on presubmit
NatashaKnk
pushed a commit
to NatashaKnk/iree
that referenced
this pull request
Jul 6, 2023
…3186) The GitHub-provided `actions/checkout` action is for some reason unusably slow on the large managed Windows runners. We assumed this was because of some tricky IO issue or something, but I decide to just try directly using `git` commands to see and lo the checkout time goes from 10 minutes to 1.5 🚀 With the caching improvements from iree-org#13183, this gets the Windows build down under 10 minutes, which means we can run it on presubmit (left for a future PR). Part of iree-org#11009 Tested: Enabled this workflow on push to my branch: https://github.com/openxla/iree/actions/runs/4750681034/jobs/8439091687 skip-ci: this only affects the Windows job, which isn't run on presubmit
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The GitHub-provided
actions/checkoutaction is for some reasonunusably slow on the large managed Windows runners. We assumed this was
because of some tricky IO issue or something, but I decide to just try
directly using
gitcommands to see and lo the checkout time goes from10 minutes to 1.5 🚀
With the caching improvements from
#13183, this gets the Windows build
down under 10 minutes, which means we can run it on presubmit (left for
a future PR).
Part of #11009
Tested:
Enabled this workflow on push to my branch:
https://github.com/openxla/iree/actions/runs/4750681034/jobs/8439091687
skip-ci: this only affects the Windows job, which isn't run on presubmit