Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Replacing --driver= with --device= and adding list flags. #9443

Merged
merged 4 commits into from
Jun 10, 2022
Merged

Replacing --driver= with --device= and adding list flags. #9443

merged 4 commits into from
Jun 10, 2022

Commits on Jun 10, 2022

  1. Adding --list_drivers, --list_devices, and --dump_devices flags. 

    These allow for querying of registered drivers, all devices or devices
for a particular driver, and detailed per-device information provided
by the driver implementations. The intent is that drivers can dump
relevant information like supported device features, limits, etc ala
something like nvidia-smi or vulkaninfo.

CUDA and Vulkan drivers have gained the ability to parse some device
paths. CUDA can now either take the UUID/MIG or device ordinal and Vulkan
currently can only take a device ordinal. With the URI scheme this means
these all work to reference the same device:
```
--device=cuda://GPU-754d9ae2-8df5-f8e3-3502-182434a12876
--device=cuda://0
--device=cuda:0
```
(the UUID and ordinal are the same as printed by `nvidia-smi -L`)

Drivers can have arbitrarily complex paths and we can continue to add
support over time. The new listing commands act as the source of truth
for what devices are supported and how to reference them.

Progress on #9343.
    @benvanik
    benvanik committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    7876a79 View commit details
    Browse the repository at this point in the history

  2. Adding a --device flag to replace --driver. 

    This is a superset of the existing driver flag and now allows for
specifying the full device URI and multiple devices (even if no tool
currently can use them).

Progress on #9343.
    @benvanik
    benvanik committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    6b65b53 View commit details
    Browse the repository at this point in the history

  3. Replacing --driver with --device in tools.

    @benvanik
    benvanik committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    46ec250 View commit details
    Browse the repository at this point in the history

  4. Changing uses of --driver= to --device= (that I can find).

    @benvanik
    benvanik committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    bba52ae View commit details
    Browse the repository at this point in the history