Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NFC] Refactor docker scripting to generalize away from Kokoro #9841

Merged
merged 5 commits into from
Jul 19, 2022
Merged

[NFC] Refactor docker scripting to generalize away from Kokoro #9841

merged 5 commits into from
Jul 19, 2022

Conversation

GMNGeoffrey
Copy link
Contributor

@GMNGeoffrey GMNGeoffrey commented Jul 19, 2022 •
edited
Loading

Factors out a generic docker_run script from our Kokoro-specific
docker setup. This will enable reusing the scripting in GitHub actions
(follow-up PR).

@GMNGeoffrey GMNGeoffrey changed the title docker refactor Refactor docker scripting to generalize away from Kokoro Jul 19, 2022
@GMNGeoffrey GMNGeoffrey changed the title Refactor docker scripting to generalize away from Kokoro [NFC] Refactor docker scripting to generalize away from Kokoro Jul 19, 2022
@GMNGeoffrey GMNGeoffrey marked this pull request as ready for review July 19, 2022 21:01
@GMNGeoffrey GMNGeoffrey enabled auto-merge (squash) July 19, 2022 21:01
@GMNGeoffrey GMNGeoffrey requested a review from pzread July 19, 2022 21:01
@GMNGeoffrey GMNGeoffrey enabled auto-merge (squash) July 19, 2022 21:02
@GMNGeoffrey GMNGeoffrey mentioned this pull request Jul 19, 2022
Merged
@GMNGeoffrey GMNGeoffrey merged commit 696ecb9 into iree-org:main Jul 19, 2022
@GMNGeoffrey GMNGeoffrey deleted the docker-refactor branch July 19, 2022 22:02
@GMNGeoffrey GMNGeoffrey added the infrastructure Relating to build systems, CI, or testing label Jul 28, 2022
@GMNGeoffrey
Copy link
Contributor Author

Forgot to tag originally, but part of #9855

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottTodd ScottTodd ScottTodd approved these changes

@pzread pzread Awaiting requested review from pzread

Assignees
No one assigned
Labels
infrastructure Relating to build systems, CI, or testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GMNGeoffrey @ScottTodd