Move ASAN over to new CI system #9958
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rsuderman
force-pushed
the
AddAsan
branch
4 times, most recently
from
7d3b116
to
fe4a8b7
Compare
rsuderman
requested review from
GMNGeoffrey,
ScottTodd and
pzread
as code owners
GMNGeoffrey
approved these changes
Aug 1, 2022
| @@ -121,6 +121,9 @@ label_exclude_regex="($(IFS="|" ; echo "${label_exclude_args[*]?}"))" | |||
| # TODO(#5715): Fix these | |||
| declare -a excluded_tests=( | |||
| "iree/samples/simple_embedding/simple_embedding_vulkan_test" | |||
| "iree/tools/test/iree-benchmark-module.mlir.test" | |||
There was a problem hiding this comment.
Hmm I'm confused why an error here would only be popping up now?
There was a problem hiding this comment.
So I found the same tests marked as failure in the attached PR. Were we still running asan in the old CI?
There was a problem hiding this comment.
Yeah we still are. Recent passing run: https://source.cloud.google.com/results/invocations/181f49e5-b0e6-4652-93fb-a79a2b06b694
I'm guessing this is a vulkan thing. It's disabled entirely for the current asan build:
pzread
reviewed
Aug 1, 2022
Co-authored-by: Geoffrey Martin-Noble <gcmn@google.com>
Co-authored-by: Geoffrey Martin-Noble <gcmn@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #9855