Skip to content

Commit

Permalink
Fix GenClass target label in java_tool's java_toolchain
Browse files Browse the repository at this point in the history
Fixes bazelbuild/intellij#845

This causes IntelliJ resolution to fail when there's a `java_plugin` in the build.

The filegroup is `GenClass`, not `Genclass`.

```
filegroup(
    name = "GenClass",
    srcs = ["java_tools/GenClass_deploy.jar"],
)
```

This will require a new java_tools release and a patch release to 0.26.0.

Closes bazelbuild#8490.

PiperOrigin-RevId: 250487423
  • Loading branch information
jin authored and irengrig committed Jun 18, 2019
1 parent 0aeecf3 commit b339669
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tools/jdk/BUILD.java_tools
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ java_toolchain(
],
},
forcibly_disable_header_compilation = 0,
genclass = [":Genclass"],
genclass = [":GenClass"],
header_compiler = [":Turbine"],
header_compiler_direct = [":TurbineDirect"],
ijar = [":ijar"],
Expand Down
2 changes: 1 addition & 1 deletion tools/jdk/BUILD.java_tools.old
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ java_toolchain(
source_version = "8",
target_version = "8",
forcibly_disable_header_compilation = 0,
genclass = [":Genclass"],
genclass = [":GenClass"],
header_compiler = [":turbine"],
header_compiler_direct = [":turbine_direct"],
ijar = [":ijar"],
Expand Down

0 comments on commit b339669

Please sign in to comment.