server: add assertion around binary versions

Makes for a more helpful error message in cockroachdb#69828; there we're dealing
with tests that override the binary version that now fail seeing as how
the min supported version is advanced.

Release note: None

pkg/server/init.go

@@ -616,14 +616,21 @@ type initServerCfg struct {
 	testingKnobs base.TestingKnobs
 }
 
-func newInitServerConfig(cfg Config, dialOpts []grpc.DialOption) initServerCfg {
+func newInitServerConfig(
+	ctx context.Context, cfg Config, dialOpts []grpc.DialOption,
+) initServerCfg {
 	binaryVersion := cfg.Settings.Version.BinaryVersion()
 	if knobs := cfg.TestingKnobs.Server; knobs != nil {
 		if ov := knobs.(*TestingKnobs).BinaryVersionOverride; ov != (roachpb.Version{}) {
 			binaryVersion = ov
 		}
 	}
 	binaryMinSupportedVersion := cfg.Settings.Version.BinaryMinSupportedVersion()
+	if binaryVersion.Less(binaryMinSupportedVersion) {
+		log.Fatalf(ctx, "binary version (%s) less than min supported version (%s)",
+			binaryVersion, binaryMinSupportedVersion)
+	}
+
 	bootstrapAddresses := cfg.FilterGossipBootstrapAddresses(context.Background())
 	return initServerCfg{
 		advertiseAddr:             cfg.AdvertiseAddr,

pkg/server/server.go

@@ -1277,7 +1277,7 @@ func (s *Server) PreStart(ctx context.Context) error {
 			return err
 		}
 
-		initConfig := newInitServerConfig(s.cfg, dialOpts)
+		initConfig := newInitServerConfig(ctx, s.cfg, dialOpts)
 		inspectedDiskState, err := inspectEngines(
 			ctx,
 			s.engines,

pkg/server/settings_cache_test.go

@@ -59,6 +59,7 @@ func TestCachedSettingsServerRestart(t *testing.T) {
 	defer leaktest.AfterTest(t)()
 	defer log.Scope(t).Close(t)
 
+	ctx := context.Background()
 	stickyEngineRegistry := NewStickyInMemEnginesRegistry()
 	defer stickyEngineRegistry.CloseAllStickyInMemEngines()
 
@@ -105,7 +106,7 @@ func TestCachedSettingsServerRestart(t *testing.T) {
 		dialOpts, err := s.rpcContext.GRPCDialOptions()
 		require.NoError(t, err)
 
-		initConfig := newInitServerConfig(s.cfg, dialOpts)
+		initConfig := newInitServerConfig(ctx, s.cfg, dialOpts)
 		inspectState, err := inspectEngines(
 			context.Background(),
 			s.engines,