Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

prepare for 0.3.0 #268

Merged
merged 2 commits into from
Mar 15, 2024
Merged

prepare for 0.3.0 #268

merged 2 commits into from
Mar 15, 2024

Conversation

trel
Copy link
Member

@trel trel commented Mar 15, 2024

building and testing now...

@trel
Copy link
Member Author

trel commented Mar 15, 2024

remaining ones to consider...

can these be generated/filled from a known variable?

./core/src/main.cpp:188:    "$id": "https://schemas.irods.org/irods-http-api/0.3.0/schema.json",
./test/config.py:9:    'url_base': '/irods-http-api/0.3.0',
./test/config.py:33:    '$id': 'https://schemas.irods.org/irods-http-api/test/0.3.0/test-schema.json',

@korydraughn
Copy link
Contributor

main.cpp - I believe this is doable. I can investigate for the next release. For 0.3.0, I think we leave it for now.

config.py - Yes, but it may be awkward to do. The best thing to do is to make it use <version> as well. Then it's on the dev to make sure they use the correct version number.

@korydraughn
Copy link
Contributor

The CMakeLists.txt defines macros which are used in main.cpp. The version is likely already available to main.cpp, we just have to tweak the code.

@trel
Copy link
Member Author

trel commented Mar 15, 2024

got it. i'll leave these three for now, and we'll tackle post-0.3.0.

@trel
Copy link
Member Author

trel commented Mar 15, 2024

merging. and one more build/test cycle with the real SHA before pushing to docker hub.

@korydraughn
Copy link
Contributor

Sounds good.

@trel
Copy link
Member Author

trel commented Mar 15, 2024

Captured in #269

@trel trel merged commit 48b6375 into irods:main Mar 15, 2024
2 checks passed
@trel trel deleted the 030bump branch March 15, 2024 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants