Make the default pool host ipv6 compatible #3356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default if you listen on 0.0.0.0 then the node net server won't listen on the ipv6 adapter. IF you listen on :: which is the ipv6 equivilent it will set the net server in multi adapter mode and listen on both ipv6 and ipv4. If you want ipv6 only there is an extra parameter.
|
Just want to verify the expected behavior is auto-listen on ipv4 |
jowparks
approved these changes
Feb 8, 2023
mat-if
approved these changes
Feb 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
By default if you listen on 0.0.0.0 then the node net server won't listen on the ipv6 adapter. IF you listen on :: which is the ipv6 equivilent it will set the net server in multi adapter mode and listen on both ipv6 and ipv4. If you want ipv6 only there is an extra parameter.
Read more, nodejs/node#9390
Testing Plan
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and
what additional work is required, if any.