Multisig: fetch participant identities from the public key package #4920
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When importing a multisig account, participant identities are stored in two places: 1. the public key package (part of the account record in the walletdb) 2. on dedicated records in the walletdb The #2 records can sometimes get lost. This is the case currently of account rescans. Because there is no future development scheduled that will benefit from #2, it's easier to just ignore those records and instead rely only on the public key package.
andiflabs
added
the
breaking-change-sdk
hughy
approved these changes
Apr 22, 2024
| identity: Buffer, | ||
| tx?: IDatabaseTransaction, | ||
| ): Promise<void> { | ||
| await this.participantIdentities.put([account.prefix, identity], { identity }, tx) |
There was a problem hiding this comment.
should we remove this datastore from the walletdb altogether?
maybe in a separate pr
andiflabs
deleted the
andrea/multisig-do-not-store-identities-separately
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When importing a multisig account, participant identities are stored in two places:
The #2 records can sometimes get lost. This is the case currently of account rescans.
Because there is no future development scheduled that will benefit from #2, it's easier to just ignore those records and instead rely only on the public key package.
Testing Plan
Unit tests
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.