Rahul/validate correct public address on import #4950
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dguenther
approved these changes
May 7, 2024
ironfish/src/wallet/validator.ts
Outdated
|
|
||
| if (isValidIVKAndPublicAddressPair(toImport.incomingViewKey, toImport.publicAddress)) { | ||
| throw new Error( | ||
| `Public address ${toImport.publicAddress} does not match public address generated from incoming view key ${toImport.incomingViewKey}`, |
There was a problem hiding this comment.
It might be nice to also log the address generated from the incoming view key -- might give someone a clue as to why they don't match.
Adds a public to the rust node js bindings that returns a public address from an IVK.
patnir
force-pushed
the
rahul/validate-correct-public-address-on-import
branch
from
8f7731a to
dff9c04
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Validates public address is accurate for corresponding keys on import
Adds a public to the rust node js bindings that returns a public address from an IVK.
Testing Plan
Manual testing + unit tests
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.