determines raw tx sender from tx fields #4970
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
uses the spends, outputs, and/or mints in a raw transaction to determine which account to use to post the transaction. deprecates the account flag from the 'wallet:post' CLI command deprecates the account request parameter from the 'wallet/postTransaction' RPC
correctly loads account by public address
mat-if
approved these changes
May 20, 2024
| } else if (this.outputs.length > 0) { | ||
| return this.outputs[0].note.sender() | ||
| } else if (this.mints.length > 0) { | ||
| return this.mints[0].creator |
There was a problem hiding this comment.
This should technically be .owner, but I see that RawTransaction lacks that information right now. We'll need to tackle that if/when ownership v2 comes around. No action needed here, just mentioning it
do not preserve state between tests
avoids building chain state
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
uses the spends, outputs, and/or mints in a raw transaction to determine which account to use to post the transaction.
deprecates the account flag from the 'wallet:post' CLI command
deprecates the account request parameter from the 'wallet/postTransaction' RPC
Testing Plan
manual testing
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.