Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sorts accounts by name in 'wallet:transaction:view' #4974

Merged
merged 1 commit into from
May 22, 2024

Conversation

hughy
Copy link
Contributor

@hughy hughy commented May 22, 2024

Summary

displays account names in alphabetical order when no account is specified by flags

Testing Plan

before:
image

after:
image

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

displays account names in alphabetical order when no account is specified by
flags
@hughy hughy requested a review from a team as a code owner May 22, 2024 21:49
@dguenther
Copy link
Member

Nice, this is super useful! 🎉

@hughy hughy merged commit cb912d3 into staging May 22, 2024
10 checks passed
@hughy hughy deleted the fix/hughy/ifl-2557/tx-view-account-sort branch May 22, 2024 22:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants