Fix migration 031 to use proper multisig encoder #4978
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
031 is not using the correct multisig encoder that matches AccountValue. This leads to errors when you try to use the new migration for 31 in any future migration such as 32.
NullSoldier
force-pushed
the
jason/31-migration
branch
from
84934d2 to
c410d1f
Compare
patnir
reviewed
May 22, 2024
Comment on lines
53
to
57
| if (value.multisigKeys) { | ||
| bw.writeVarBytes(Buffer.from(value.multisigKeys.secret, 'hex')) | ||
| bw.writeVarBytes(Buffer.from(value.multisigKeys.keyPackage, 'hex')) | ||
| const encoding = new MultisigKeysEncoding() | ||
| bw.writeU64(encoding.getSize(value.multisigKeys)) | ||
| bw.writeBytes(encoding.serialize(value.multisigKeys)) | ||
| } |
There was a problem hiding this comment.
Does this break the current multisig accounts because of the size also being written?
There was a problem hiding this comment.
Maybe this change doesn't matter because there were no multisig accounts before 31?
There was a problem hiding this comment.
Yes that's correct. If this ran for anyone in the first place, their accounts would not be de-codable. It would crash when they try to start the node.
patnir
approved these changes
May 23, 2024
dguenther
approved these changes
May 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
031 is not using the correct multisig encoder that matches AccountValue. This leads to errors when you try to use the new migration for 31 in any future migration such as 32.
Testing Plan
Run the migration on an old database.
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.