adds account flag to wallet commands #4994
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
some wallet commands take 'account' as a positional argument when it may make more sense as a flag. adds account flag to commands that list things for an account: assets, balances, notes, transactions adds account flag where commands are oriented around a transaction rather than an account: wallet:transaction, wallet:transaction:watch parse flags and args so that account flag is preferred, but account arg still accepted updates arg description to display that argument is deprecated
patnir
approved these changes
Jun 6, 2024
NullSoldier
reviewed
Jun 6, 2024
NullSoldier
approved these changes
Jun 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
some wallet commands take 'account' as a positional argument when it may make more sense as a flag.
adds account flag to commands that list things for an account: assets, balances, notes, transactions
adds account flag where commands are oriented around a transaction rather than an account: wallet:transaction, wallet:transaction:watch
parse flags and args so that account flag is preferred, but account arg still accepted
updates arg description to display that argument is deprecated
Testing Plan
manual testing
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.