Remove unnecessary trims from CLI commands #5031
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
oclif already trims by default. By adding these trims, we're overriding the behavior of oclif and closing unintentional escape hatches for cases where a leading/trailing space might be intended when wrapping the arg or flag in quotation marks.
hughy
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
oclif already trims by default. By adding these trims, we're overriding the behavior of oclif and closing unintentional escape hatches for cases where a leading/trailing space might be intended when wrapping the arg or flag in quotation marks.
There are a few more places where
trimis being used in the CLI commands, but they are generally being used as part of more complex split functions, or are deep enough down the call stack that I didn't want to potentially cause issues for now.Testing Plan
Documentation
N/A
Breaking Change
N/A