Move usage of RpcAccountImport to exporter system #5034
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NullSoldier
commented
Jun 11, 2024
NullSoldier
commented
Jun 11, 2024
NullSoldier
commented
Jun 11, 2024
NullSoldier
commented
Jun 11, 2024
dguenther
reviewed
Jun 11, 2024
| proofAuthorizingKey: string | null | ||
| } | ||
|
|
||
| const AccountEncodedJSONSchema: yup.ObjectSchema<AccountEncodedJSON> = yup |
There was a problem hiding this comment.
This schema doesn't quite match the type AccountEncodedJSON, I'm guessing that's where some of the test failures are from
There was a problem hiding this comment.
Interestingly enough, I didn't actually change this. This is the old schema from RpcAccountImport. That means this is now catching failures that always existed now that we're actually checking the schema on import. That's a good thing. I'll investigate and make the schema match!
There was a problem hiding this comment.
This is fixed now in 135043f
dguenther
approved these changes
Jun 11, 2024
NullSoldier
force-pushed
the
jason/rpc-account-import
branch
from
950d68e to
7839a18
Compare
This old type was only used by the RPC system, but now is moving into the JSON encoder to show that it's only used by the JSON encoding system to export an AccountImport into JSON.
This must throw DecodeFailed or else it will crash if decoding using this decoder failed.
The encoder is deprecated because you cannot encode accounts anymore using it. This test was still trying to encode a new account import format with an old deprecated encoder.
NullSoldier
force-pushed
the
jason/rpc-account-import
branch
from
7839a18 to
994ff31
Compare
NullSoldier
force-pushed
the
jason/rpc-account-import
branch
from
af6b027 to
32d3b49
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This old type was only used by the RPC system, but now is moving into the JSON encoder to show that it's only used by the JSON encoding system to export an AccountImport into JSON.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.