Introduce optional pagination to ChainProcessor #5068
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiflabs
approved these changes
Jun 24, 2024
|
|
||
| blockCount++ | ||
| if (this.maxQueueSize && blockCount >= this.maxQueueSize) { | ||
| return { hashChanged: !oldHash || !this.hash.equals(oldHash) } |
There was a problem hiding this comment.
Nit: given that this is repeated in multiple places, we could have an anonymous fn like this:
const returnValue = () => ({ hashChanged: !oldHash || !this.hash.equals(oldHash) })and then change all the return { ... } statements to:
return returnValue()There was a problem hiding this comment.
I have one more recommendation for this that I put in another PR here, #5073.
NullSoldier
force-pushed
the
jason/pagination
branch
from
33d52bc to
f0a1597
Compare
andiflabs
approved these changes
Jun 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds similar optional pagination that the RemoteChainProcessor has to the ChainProcessor. This is useful if you want to stop after a certain amount of blocks to perform other work.
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.