Use an optimized method for note decryption when multiple accounts are present #5119
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…e present When multiple accounts are present, instead of decrypting each note for each account, one by one, use an optimized method that can save some computation cycles.
andiflabs
force-pushed
the
andrea/note-decrypt-multiply-many
branch
from
9301143 to
2e42f19
Compare
hughy
approved these changes
Jul 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
When multiple accounts are present, instead of decrypting each note for each account, one by one, use an optimized method that can save some computation cycles.
This is a draft because it requires iron-fish/jubjub#4 to be merged first.
Testing Plan
ironfish wallet:rescanDocumentation
N/A
Breaking Change
N/A