Optimize WalletDB.loadNoteHash() to avoid hitting the database if the note nullifier is known to be absent
#5135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hughy
approved these changes
Jul 16, 2024
Comment on lines
1297
to
1298
| // TODO: maybe keep a count of how many times this method was called, and | ||
| // reset the bloom filter after a certain threshold |
There was a problem hiding this comment.
I don't think we need to worry about nullifiers here. Entries in nullifierToTransactionHash are only deleted if a pending transaction expires. The nullifier is still valid for that account, but that transaction isn't.
Comment on lines
817
to
818
| // TODO: maybe keep a count of how many times this method was called, and | ||
| // reset the bloom filter after a certain threshold |
There was a problem hiding this comment.
I think that nullifiers are deleted so infrequently that it might not be worth the added complexity to reset the bloom filter
There was a problem hiding this comment.
Agreed, that's why I did not implement it. I might turn this "TODO" into a simple comment saying that the bloom filter is unchanged after a delete, and that's by design, because <explanation>.
andiflabs
commented
Jul 16, 2024
…he note nullifier is known to be absent This commit adds an in-memory bloom filter to remember which nullifiers are stored in the database. The bloom filter is used by `WalletDB.loadNoteHash()` to avoid querying the database if the given nullifier is known to be not present. While at it, `WalletDB.getTransactionHashFromNullifier()` was optimized in the same way.
andiflabs
force-pushed
the
andrea/bloom-filter-for-spent-notes
branch
from
115dcb3 to
6207960
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This commit adds an in-memory bloom filter to remember which nullifiers are stored in the database. The bloom filter is used by
WalletDB.loadNoteHash()to avoid querying the database if the given nullifier is known to be not present.While at it,
WalletDB.getTransactionHashFromNullifier()was optimized in the same way.Testing Plan
wallet:rescanDocumentation
N/A
Breaking Change
N/A