Add Config, DataDir and Verbose flags as base flags to all commands #5174
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes LocalFlags entirely, as well as removing these 3 flags from RemoteFlags.
NullSoldier
approved these changes
Jul 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This removes LocalFlags entirely, as well as removing these 3 flags from RemoteFlags.
Only 2 or 3 non-hidden commands didn't utilize all 3 of these, and it was mostly the verbose flag, so there are scenarios where verbose will be listed as an argument but doesn't do anything, which I think is an okay trade-off. It's not ideal, but ensuring these flags are present seems very beneficial.
This has the added benefit of throwing compile errors if a command tries to use a flag it hasn't defined. For some reason, if baseFlags is undefined/empty object, it seems to break the strict typing of flags. Closes IFL-2826
Testing Plan
Documentation
N/A
Breaking Change
N/A