feat(ironfish,rust-nodejs): Add EncryptedAccount class #5226
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rohanjadvani
commented
Aug 8, 2024
| serialize(value: AccountValue): Buffer { | ||
| export type AccountValue = EncryptedAccountValue | DecryptedAccountValue | ||
|
|
||
| export class AccountValueEncoding implements IDatabaseEncoding<DecryptedAccountValue> { |
There was a problem hiding this comment.
This is a temporary change to update the generic and will be changed back to AccountValue (the new union type) in a subsequent PR. We are using DecryptedAccountValue to keep code changes small per PR, and the change will come once the wallet and walletdb are updated to read / store encrypted accounts.
rohanjadvani
commented
Aug 8, 2024
| async *loadAccounts(tx?: IDatabaseTransaction): AsyncGenerator<AccountValue, void, unknown> { | ||
| async *loadAccounts( | ||
| tx?: IDatabaseTransaction, | ||
| ): AsyncGenerator<DecryptedAccountValue, void, unknown> { |
There was a problem hiding this comment.
Same comment above regarding the generic. Will update once encrypted account encoding is added.
rohanjadvani
commented
Aug 8, 2024
| const encoder = new AccountValueEncoding() | ||
| const data = encoder.serialize(account.serialize()) | ||
|
|
||
| const encryptedData = encrypt(data, passphrase) |
There was a problem hiding this comment.
Will be refactored when the decrypted account has an encrypt method for better encapsulation.
mat-if
approved these changes
Aug 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
encrypt/decryptto accept and return JS buffersAccountValuetoDecryptedAccountValueencryptedproperty to be used as a type guard in subsequent PRsEncryptedAccountValueto represent encrypted accounts in the databaseTesting Plan
Unit test
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.