Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change wallet:status to output aggregation #5275

Merged
merged 1 commit into from
Aug 14, 2024
Merged

Conversation

NullSoldier
Copy link
Contributor

@NullSoldier NullSoldier commented Aug 14, 2024

Summary

You can now use ironfish wallet --extended to get the output you would from here previously.

This is a part of the great CLI usability improvement of 2024 because Iron Fish is dedicated to having the best CLI usability of any developer focused product out there.

> ironfish wallet:status
Wallet:          ENABLED
Accounts:        3
Head:            00000000000159179cdb59cbf348dc5bc47cec391248cb7a0a174d5f6a43a90d
Sequence:        697330
Scanner:         SCANNING
Scan Progress:   71.49%
Scan Speed:      887.33 B/s
Scan Duration:   9m 55s
Scan Block:      498534 -> 697330
> ironfish wallet:status --json
{
  "enabled": true,
  "head": {
    "hash": "000000000000ff6f83ab7832758afc332b1f7339098f11b76c9cd0d075e79384",
    "sequence": 697318
  },
  "scanning": {
    "sequence": 665162,
    "hash": "000000000000c56af24c2381716a699b6c684a065ceb1e47d65725daadaf2c4f",
    "startSequence": 1,
    "endSequence": 697318,
    "startedAt": 1723673549222,
    "speed": 810.6445700897798
  },
  "accountsCount": 3
}

Testing Plan

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

@NullSoldier NullSoldier requested a review from a team as a code owner August 14, 2024 22:27
@NullSoldier NullSoldier merged commit 67b47b2 into staging Aug 14, 2024
13 checks passed
@NullSoldier NullSoldier deleted the jason/cmd-status branch August 14, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants