multisig broker server broadcasts on step completions #5476
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mat-if
approved these changes
Oct 3, 2024
uses maxSigners for dkg and numSigners for signing to broadcast the session status once the required number of participants have submitted data of a particular type removes broadcasts of individual identities, packages, etc. removes client handlers for messages containing individual identities, packages, etc. simplifies client logic for waiting on data from server: only uses status messages instead of listening for individual identities etc AND polling status distinguishes message methods for dkg identities and signing identities. the message bodies are the same, but it allows the server to distinguish how to handle the session
hughy
force-pushed
the
feat/hughy/multisig-broadcasts
branch
from
279cf7b to
7774f68
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
uses maxSigners for dkg and numSigners for signing to broadcast the session status once the required number of participants have submitted data of a particular type
removes broadcasts of individual identities, packages, etc.
removes client handlers for messages containing individual identities, packages, etc.
simplifies client logic for waiting on data from server: only uses status messages instead of listening for individual identities etc AND polling status
distinguishes message methods for dkg identities and signing identities. the message bodies are the same, but it allows the server to distinguish how to handle the session
Closes IFL-3024
Testing Plan
manual testing:
wallet:multisig:dkg:createvia serverwallet:multisig:signvia serverDocumentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.