prevents incorrect session encryption from halting process #5483
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
if a client submits data to the broker server encrypted with the wrong passphrase and key then all other clients will now skip that data adds a 'challenge' to the session which is a string encrypted with the session passphrase and key if a client fails to decrypt the challenge then the client throws an error decrypts message data only when necessary
hughy
force-pushed
the
feat/hughy/session-decryption
branch
from
a94c736 to
a7279a9
Compare
mat-if
approved these changes
Oct 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
if a client submits data to the broker server encrypted with the wrong passphrase and key then all other clients will now skip that data
adds a 'challenge' to the session which is a string encrypted with the session passphrase and key
if a client fails to decrypt the challenge then the client throws an error
decrypts message data only when necessary
Closes IFL-3028
Testing Plan
manual testing:
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.