Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add flags for minSigners and totalParticipants for dkg:create #5497

Merged
merged 2 commits into from
Oct 7, 2024

Conversation

mat-if
Copy link
Contributor

@mat-if mat-if commented Oct 7, 2024

Summary

Makes it a little easier to get through the setup phase for power users

Testing Plan

  • Test with server and with flags: Should not prompt for total participants and min signers
    wallet:multisig:dkg:create --server <...> --totalParticipants 2 --minSigners 2
  • Test with server and without flags: Should prompt for total participants and min signers
    wallet:multisig:dkg:create --server <...>
  • Test without server and with flags: Should not prompt for total participants and min signers
    wallet:multisig:dkg:create --totalParticipants 2 --minSigners 2
  • Test without server and without flags: Should prompt for total participants and min signers
    wallet:multisig:dkg:create
  • Test with sessionId and with flags: Should throw an error due to these flags being exclusive
    wallet:multisig:dkg:create --sessionId foo --totalParticipants 2 --minSigners 2
  • Test with sessionId and without flags: Should not throw an error
    wallet:multisig:dkg:create --sessionId foo

Documentation

Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference
)? If yes, link a
related documentation pull request for the website.

[ ] Yes

Breaking Change

Is this a breaking change? If yes, add notes below on why this is breaking and label it with breaking-change-rpc or breaking-change-sdk.

[ ] Yes

@mat-if mat-if requested a review from a team as a code owner October 7, 2024 23:00
Copy link
Contributor

@hughy hughy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one additional suggestion: if a user sets either --totalParticipants or --minSigners they must start a new session, so we should skip the sessionId prompt

@mat-if mat-if merged commit bcafa95 into staging Oct 7, 2024
9 checks passed
@mat-if mat-if deleted the mat/dkg-flags branch October 7, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants