Avoid connect handshake and handle all error cases #5512
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds new documentation about what and which errors are thrown. It also removes appInfo() and getVersion() during tryInstruction because it duplicates the error cdoes you get from just running any app commands. This also transforms ledger app errors from TransportStatusError into ResponseError so we can handle all the error codes in a single way.
NullSoldier
force-pushed
the
jason/ledger-errors
branch
from
e266ae7 to
de33d1e
Compare
hughy
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This adds new documentation about what and which errors are thrown. It
also removes appInfo() and getVersion() during tryInstruction because it
duplicates the error cdoes you get from just running any app commands.
This also transforms ledger app errors from TransportStatusError into
ResponseError so we can handle all the error codes in a single way.
The original investigation of this fix was done by @hughy and we furthered the research on figuring out that the entire connect handshake is not needed.
Original PR: #5511
Testing Plan
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.