move and refactor proof generation key serialization to ironfish-zkp #5559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jowparks
force-pushed
the
proof-generation-key-zkp
branch
3 times, most recently
from
3e00045 to
228e3f6
Compare
jowparks
changed the title
jowparks
force-pushed
the
proof-generation-key-zkp
branch
2 times, most recently
from
d68778d to
fb4a6f2
Compare
jowparks
commented
Oct 17, 2024
jowparks
force-pushed
the
proof-generation-key-zkp
branch
from
fb4a6f2 to
3bc27e6
Compare
jowparks
commented
Oct 17, 2024
jowparks
commented
Oct 17, 2024
andiflabs
approved these changes
Oct 17, 2024
jowparks
force-pushed
the
proof-generation-key-zkp
branch
from
3bc27e6 to
defd944
Compare
jowparks
force-pushed
the
proof-generation-key-zkp
branch
from
defd944 to
d4d405a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Moves
ProofGenerationKeytoironfish-zkpand instead of using an extension trait, creates an ironfish owned typeTesting Plan
tests pass
Documentation
Does this change require any updates to the Iron Fish Docs (ex. the RPC API
Reference)? If yes, link a
related documentation pull request for the website.
Breaking Change
Is this a breaking change? If yes, add notes below on why this is breaking and label it with
breaking-change-rpcorbreaking-change-sdk.