WASM: enable in-browser tests through wasm-bindgen-test
#5646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andiflabs
force-pushed
the
andrea/ironfish-rust-wasm-public-addr
branch
from
f55f5f7 to
ff4ba00
Compare
andiflabs
force-pushed
the
andrea/ironfish-rust-wasm-bindgen-tests
branch
from
19aeceb to
c0d5cc7
Compare
mat-if
approved these changes
Nov 13, 2024
Base automatically changed from
andrea/ironfish-rust-wasm-public-addr
to
staging
November 13, 2024 21:58
The unit tests currently are marked with both `#[test]` and `#[wasm_bindgen_test]`. This allows tests to run with both `cargo test` and `wasm-pack test`. In theory, we could drop `#[test]`, but given that `cargo test` is faster than `wasm-pack test`, this makes developing easier, so I'm keeping it for now.
andiflabs
force-pushed
the
andrea/ironfish-rust-wasm-bindgen-tests
branch
from
c0d5cc7 to
013cf4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
The unit tests currently are marked with both
#[test]and#[wasm_bindgen_test]. This allows tests to run with bothcargo testandwasm-pack test.In theory, we could drop
#[test], but given thatcargo testis faster thanwasm-pack test, this makes developing easier, so I'm keeping it for now.Testing Plan
One or more of the following:
cd ironfish-rust-wasm && wasm-pack test --firefox --headlesscd ironfish-rust-wasm && wasm-pack test --chrome --headlesscd ironfish-rust-wasm && wasm-pack test --safari --headless--headlessis not required (it makes the output appear on the terminal instead of in the browser)Documentation
N/A
Breaking Change
N/A