Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Run tests on the WASM package as part of the GitHub workflow #5647

Merged
merged 1 commit into from
Nov 13, 2024
Merged

Run tests on the WASM package as part of the GitHub workflow #5647

merged 1 commit into from
Nov 13, 2024

Conversation

andiflabs
Copy link
Contributor

@andiflabs andiflabs commented Nov 13, 2024 •
edited
Loading

Summary

  • Expanded the license header check to include the wasm crate (and fixed the files that did not have the header)
  • Added a workflow to run the wasm tests in Chrome and Firefox

Testing Plan

Example run: https://github.com/iron-fish/ironfish/actions/runs/11809229845/job/32899173267?pr=5647

Documentation

N/A

Breaking Change

N/A

@andiflabs andiflabs requested a review from a team as a code owner November 13, 2024 01:57
@andiflabs andiflabs force-pushed the andrea/ironfish-rust-wasm-github-tests branch from 4a6b13a to c240e9f Compare November 13, 2024 02:02
@andiflabs andiflabs force-pushed the andrea/ironfish-rust-wasm-bindgen-tests branch from 19aeceb to c0d5cc7 Compare November 13, 2024 02:04
@andiflabs andiflabs force-pushed the andrea/ironfish-rust-wasm-github-tests branch from c240e9f to da30d15 Compare November 13, 2024 02:04
@andiflabs andiflabs force-pushed the andrea/ironfish-rust-wasm-bindgen-tests branch from c0d5cc7 to 013cf4e Compare November 13, 2024 21:59
Base automatically changed from andrea/ironfish-rust-wasm-bindgen-tests to staging November 13, 2024 22:05
@andiflabs andiflabs force-pushed the andrea/ironfish-rust-wasm-github-tests branch from da30d15 to 5d89c4a Compare November 13, 2024 22:41
@andiflabs andiflabs enabled auto-merge (rebase) November 13, 2024 22:41
@andiflabs andiflabs merged commit c41047e into staging Nov 13, 2024
24 checks passed
@andiflabs andiflabs deleted the andrea/ironfish-rust-wasm-github-tests branch November 13, 2024 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mat-if mat-if mat-if approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andiflabs @mat-if