Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for Volume resize #104

Merged
merged 8 commits into from
Jan 16, 2024
Merged

Support for Volume resize #104

merged 8 commits into from
Jan 16, 2024

Conversation

lukasfrank
Copy link
Member

Proposed Changes

  • Added Volume resize support
  • Added GetSize to the volume plugin interface

Fixes #58

@lukasfrank
Volume resize
2f1ee4e 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
@lukasfrank
Merge branch 'main' into enh/volume-resize
8d868ee
@github-actions github-actions bot added size/L controllers enhancement New feature or request labels Jan 10, 2024
@lukasfrank
Volume resize
1249e70 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
lukas016
lukas016 requested changes Jan 10, 2024
View reviewed changes
pkg/api/machine.go Show resolved Hide resolved
pkg/controllers/machine_controller.go Outdated Show resolved Hide resolved
pkg/controllers/machine_controller.go Outdated Show resolved Hide resolved
pkg/controllers/machine_controller.go Outdated Show resolved Hide resolved
pkg/controllers/machine_controller_volumes.go Show resolved Hide resolved
pkg/plugins/volume/ceph/size.go Show resolved Hide resolved
pkg/plugins/volume/ceph/size.go Outdated Show resolved Hide resolved
@lukasfrank lukasfrank marked this pull request as ready for review January 10, 2024 13:51
@lukasfrank lukasfrank requested a review from a team as a code owner January 10, 2024 13:51
lukas016
lukas016 requested changes Jan 10, 2024
View reviewed changes
pkg/controllers/machine_controller.go Outdated Show resolved Hide resolved
pkg/controllers/machine_controller.go Outdated Show resolved Hide resolved
pkg/controllers/machine_controller.go Outdated Show resolved Hide resolved
@lukasfrank
Review
1e6ff11 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
afritzler
afritzler requested changes Jan 10, 2024
View reviewed changes
provider/cmd/app/app.go Outdated Show resolved Hide resolved
pkg/plugins/volume/ceph/size.go Show resolved Hide resolved
@lukasfrank
Review
8c8297d 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
@lukasfrank
Review
0812366 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
@lukasfrank
Review
c9e2ce5 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
afritzler
afritzler requested changes Jan 11, 2024
View reviewed changes
pkg/controllers/machine_controller.go Outdated Show resolved Hide resolved
pkg/controllers/machine_controller.go Outdated Show resolved Hide resolved
pkg/plugins/volume/ceph/size.go Show resolved Hide resolved
@lukasfrank
Review
ffe77ff 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
@lukasfrank lukasfrank merged commit 5b55da5 into main Jan 16, 2024
8 checks passed
@lukasfrank lukasfrank deleted the enh/volume-resize branch January 16, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@afritzler afritzler afritzler approved these changes

@lukas016 lukas016 Awaiting requested review from lukas016

Assignees
No one assigned
Labels
controllers enhancement New feature or request size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Support for Resizing Attached Ceph Volumes
3 participants
@lukasfrank @afritzler @lukas016