Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add logger to main package and improve logging #135

Merged
merged 5 commits into from
Jan 23, 2024
Merged

Add logger to main package and improve logging #135

merged 5 commits into from
Jan 23, 2024

Conversation

lukasfrank
Copy link
Member

Proposed Changes

Improved logging

  • Replaced main error logging from fmt.Println to logger
  • Removed redundant logging by logger and cobra
  • Disabled usage help once the flags are parsed

Fixes #85

@lukasfrank lukasfrank requested a review from a team as a code owner January 22, 2024 15:14
@github-actions github-actions bot added size/S enhancement New feature or request labels Jan 22, 2024
@lukasfrank lukasfrank mentioned this pull request Jan 22, 2024
Closed
@lukasfrank
Improve logging
fc71c22 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
afritzler
afritzler requested changes Jan 22, 2024
View reviewed changes
provider/cmd/main.go Outdated Show resolved Hide resolved
afritzler
afritzler previously approved these changes Jan 22, 2024
View reviewed changes
@lukasfrank
Unified log messages
0013fe3 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
@github-actions github-actions bot added size/M and removed size/S labels Jan 22, 2024
@afritzler afritzler changed the title Improved logging Add logger to main package and improve logging Jan 22, 2024
lukas016
lukas016 reviewed Jan 23, 2024
View reviewed changes
provider/cmd/app/app.go Outdated Show resolved Hide resolved
provider/cmd/main.go Outdated Show resolved Hide resolved
@lukasfrank
PR comments
4ee332b 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
@lukasfrank lukasfrank added the integration-tests to run integration tests label Jan 23, 2024
@lukasfrank lukasfrank merged commit 01cff08 into main Jan 23, 2024
9 checks passed
@lukasfrank lukasfrank deleted the enh/logging branch January 23, 2024 10:00
@lukasfrank lukasfrank self-assigned this Jan 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukas016 lukas016 lukas016 approved these changes

@afritzler afritzler afritzler left review comments

Assignees

@lukasfrank lukasfrank

Labels
enhancement New feature or request integration-tests to run integration tests size/M
Projects
Compute
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve app logging
3 participants
@lukasfrank @afritzler @lukas016