Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Machine Reconciler #28

Merged
merged 7 commits into from
Nov 7, 2023
Merged

Machine Reconciler #28

merged 7 commits into from
Nov 7, 2023

Conversation

lukasfrank
Copy link
Member

Proposed Changes

Fixes #

@github-actions github-actions bot added size/XXL enhancement New feature or request labels Oct 31, 2023
# Conflicts:
#	driver/cmd/app/app.go
#	driver/server/machine_create.go
#	pkg/controllers/machine_controller.go
#	pkg/controllers/volume_controller.go
#	pkg/plugins/volume/ceph/ceph.go
#	pkg/plugins/volume/emptydisk/emptydisk.go
#	pkg/plugins/volume/plugins.go
@lukasfrank lukasfrank force-pushed the enh/machine-volume branch 3 times, most recently from 5baf967 to 2dd839e Compare November 2, 2023 13:12
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would merge this one (already too big)and have a new one to implement further changes.

@hardikdr hardikdr merged commit b3cd3b7 into main Nov 7, 2023
7 checks passed
@hardikdr hardikdr deleted the enh/machine-volume branch November 7, 2023 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request size/XXL
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants