Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extend Server Tests to Cover ListEvents #370

Merged
merged 5 commits into from
Aug 20, 2024
Merged

Extend Server Tests to Cover ListEvents #370

merged 5 commits into from
Aug 20, 2024

Conversation

so-sahu
Copy link
Contributor

@so-sahu so-sahu commented Aug 13, 2024

Fixes #366

@so-sahu so-sahu self-assigned this Aug 13, 2024
@so-sahu so-sahu requested a review from a team as a code owner August 13, 2024 06:37
@lukas016 lukas016 force-pushed the osc/extend-server-tests-to-cover-ListEvents branch from d5b212e to ff6a5e1 Compare August 13, 2024 06:40
@so-sahu so-sahu added the integration-tests to run integration tests label Aug 13, 2024
@so-sahu so-sahu changed the title Osc/extend server tests to cover list events Extend Server Tests to Cover ListEvents Aug 13, 2024
@so-sahu so-sahu marked this pull request as draft August 13, 2024 07:06
@lukas016 lukas016 force-pushed the osc/extend-server-tests-to-cover-ListEvents branch from 63c2dd3 to 5573c08 Compare August 13, 2024 08:04
@so-sahu so-sahu marked this pull request as ready for review August 13, 2024 08:45
lukasfrank
lukasfrank requested changes Aug 16, 2024
View reviewed changes
internal/server/event_list_test.go Outdated Show resolved Hide resolved
internal/server/event_list_test.go Show resolved Hide resolved
@lukas016 lukas016 force-pushed the osc/extend-server-tests-to-cover-ListEvents branch from ea32ead to e8c6d6a Compare August 20, 2024 08:27
@lukasfrank lukasfrank merged commit 1724af2 into ironcore-dev:main Aug 20, 2024
9 checks passed
lukas016 pushed a commit to opensovereigncloud/libvirt-provider that referenced this pull request Aug 28, 2024
@so-sahu
Extend Server Tests to Cover ListEvents (ironcore-dev#370)
0549955
@afritzler afritzler added the enhancement New feature or request label Aug 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukasfrank lukasfrank lukasfrank approved these changes

@lukas016 lukas016 Awaiting requested review from lukas016

Assignees

@so-sahu so-sahu

Labels
enhancement New feature or request integration-tests to run integration tests size/L
Projects
Compute
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Extend the Server tests to cover ListEvents
3 participants
@so-sahu @lukasfrank @afritzler