Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup of unused code #86

Merged
merged 1 commit into from
Dec 21, 2023
Merged

Cleanup of unused code #86

merged 1 commit into from
Dec 21, 2023

Conversation

lukasfrank
Copy link
Member

Proposed Changes

  • Removed not used code

@lukasfrank
Removed unused code
87b4b6e 
Signed-off-by: Lukas Frank <lukas.frank@sap.com>
@lukasfrank lukasfrank requested a review from a team as a code owner December 21, 2023 13:48
hardikdr
hardikdr approved these changes Dec 21, 2023
View reviewed changes
Copy link
Member

@hardikdr hardikdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approving with the pov that, we can always bring back the GPU-related code when we decide to support the feature again, better designed this time.

@lukasfrank lukasfrank merged commit 3322eec into main Dec 21, 2023
7 checks passed
@lukasfrank lukasfrank deleted the cleanup branch December 21, 2023 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hardikdr hardikdr hardikdr approved these changes

Assignees
No one assigned
Labels
chore size/L
Projects
Compute
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lukasfrank @hardikdr @afritzler